Skip to content

More accurate implementation of sin using the same Taylor method - #15594

Open
nibblus wants to merge 1 commit into
TheAlgorithms:masterfrom
nibblus:math_sin
Open

nibblus wants to merge 1 commit into
TheAlgorithms:masterfrom
nibblus:math_sin

Conversation

@nibblus

@nibblus nibblus commented Oct 17, 2026

Copy link
Copy Markdown

More accurate implementation of sin using the same Taylor method

Describe your change

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?
    More accurate implementation of sin unsing Taylor series.
    Clearer way to limit angle between -360 and 360 using modulo
    Avoid recalculating factorial(x) every iteration.
    Keep calculating until next term has no longer effect on the result.

  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.

  • Documentation change?

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [] If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Clearer way to limit angle between -360 and 360 using modulo
Avoid recalculating factorial(x) every iteration.
Keep calculating until next term has no longer effect on the result.
All existing doctests still succeed.
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant