Repository navigation
[TS] Preserve Promise executor closures and settlement arguments - #622
Open
CaelmBleidd wants to merge 1 commit into
Open
CaelmBleidd wants to merge 1 commit into
CaelmBleidd wants to merge 1 commit into
Conversation
CaelmBleidd
force-pushed
the
caelmbleidd/ts-promise-settlement-arguments
branch
from
October 20, 2026 09:41
8c8eeac to
d8b0052
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/ts-promise-settlement-arguments
branch
from
October 20, 2026 09:52
d8b0052 to
0ab6234
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promise construction currently drops the materialized executor closure/receiver. Settlement requires exactly one argument, rejecting valid omitted values and ignoring extra-argument evaluation. Preserve the executor environment, use undefined for a missing settlement value, and evaluate extra arguments before ignoring them. First settlement still wins.
Relevant regression coverage: 9 source-level Promise regressions.
Combined-stack validation at
c46aa3f8b: 65 TS regressions and 22 Calls tests passed; TS and Calls Detekt main/test passed. These checks ran under the exclusive local build lock. This PR head has its own CI; the combined-stack check is not a standalone-head CI claim.Stack: targets
caelmbleidd/ts-safe-value-materialization; the diff contains only this layer. Merge/rebase prerequisites first, then move this own range onto current main. Frozen experiment artifacts and runtime files are unchanged.