test: avoid C# 14 ambiguous Contains call in UniversalRpcTests

[BrianUnity]

Purpose of this PR

UniversalRpcTests.cs does not compile with C# 14. The compiler reports error CS0121 (ambiguous call) at 12 lines like this one:

s_ClientIds.Where(c => recipient.Contains(c))

recipient is a ulong[]. C# 14 can convert an array to a ReadOnlySpan<T> automatically. Because of this, two span methods now match recipient.Contains(c):

• System.MemoryExtensions.Contains
• Unity.Collections.NativeArrayExtensions.Contains

The compiler cannot choose between them.

This PR adds a small extension method, ContainsId, that uses Array.IndexOf. The 12 lines now call recipient.ContainsId(c). The new name does not match the span methods, so the call is not ambiguous. The behavior does not change, and the code still compiles with older C# versions.

I searched the rest of the package for the same problem and found none.

Jira ticket

UUM-155844

Documentation

• No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Automated tests:

• Covered by existing automated tests

With the same Array.IndexOf check, all PlayMode tests passed on .NET 10 (5378 passed, 0 failed).

Up-port

Not needed. This PR targets the newest branch.

Backports

develop-2.0.0 and develop have the same 12 lines. They need the same fix if they must compile with C# 14.

[u-pr]

⚠️ Some settings were ignored in '.pr_agent.toml (repository root)' repo settings

Check the configuration's TOML syntax, permitted settings, and size limit. See the error below.

---

Error message:
Ignored prohibited settings: github_app.handle_pr_actions. Permitted settings were applied.

Configuration content:

# This is the configuration for the u-pr bot
# https://github.cds.internal.unity3d.com/unity/u-pr
# For configuration of this file:
# https://developer.portal.internal.unity.com/catalog/default/component/u-pr/docs/configuration/automatic_runs/

[github_app]
handle_pr_actions = ['opened', 'ready_for_review']  # PR events that auto-run pr_commands
pr_commands       = ["/harness-review"]             # what runs on those events
reviewer_commands = ["/harness-review"]             # what runs when @u-pr is added as reviewer

[u-pr]

💡 Harness Review

The helper avoids the C# 14 overload ambiguity while preserving array membership behavior. I examined all 12 replacements, the helper’s scope, and the recipient inputs in both current and legacy tests; no actionable issues were found.

_{Reviewed commit 5cce296}

_{🤖 Helpful? 👍/👎}

[codecov-github-com]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@              Coverage Diff               @@
##           develop-3.x.x    #4193   +/-   ##
==============================================
  Coverage          76.11%   76.11%           
==============================================
  Files                159      159           
  Lines              27333    27333           
==============================================
  Hits               20805    20805           
  Misses              6528     6528           

Flag	Coverage Δ
NGOv2_project_testproject_ubuntu	75.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
com.unity.netcode.gameobjects	76.11% <ø> (ø)

ℹ️ Need help interpreting these results?