Repository navigation
Take the tray pieces from PlatformHeads - #969
Merged
Merged
Conversation
DiffEngineTray takes PlatformHeads.WindowsForms. SessionEndWindow moves there, with the tray logging what its ending threw, and MenuBuilder builds the tracked items through MenuOnOpening. IssueLauncher and LinkLauncher sit on IssueLink and LinkOpener: a body is now plain text, encoded once, and PiperTest marks its message as raised through IssueLauncher.AlreadyRaised rather than by reflecting on a private field. BuildMonitor's tray takes the same pieces. All six PlatformHeads pins move to 0.5.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes PlatformHeads layer 5, the Windows tray pieces (SimonCropp/PlatformHeads#2, tagged 0.5.0):
MenuOnOpening: the tray menu's items are built on every open beside the kept ones, taken off as it closes and disposed at the next open, and an empty strip's first open still shows.SessionEndWindow: hears a session ending when the app has no form (DiffEngineTray).IssueLinkandLinkOpener, under each app'sIssueLauncherandLinkLauncher.All six PlatformHeads pins move to 0.5.0: the workflow's
uses:, CMake'sGIT_TAG, the three packages inDirectory.Packages.props, andnative/swift/Package.swift. Nothing native changed in this layer.