Repository navigation
[wasm_split] Fix crash when manifest starts with a blank line - #9264
Open
sorensp-goog wants to merge 1 commit into
Open
sorensp-goog wants to merge 1 commit into
sorensp-goog wants to merge 1 commit into
Conversation
sorensp-goog
requested review from
stevenfontanella
and removed request for
a team
October 15, 2026 14:37
Member
|
Can you give an example repro program + wasm-split invocation that demonstrates the crash, and ideally add a lit test as well? I see some wasm-split lit tests in |
Author
There is no repro program as such, but any manifest that starts with a blank line will provoke a crash. I added a lit test that covers various aspect of this state machine, including this one. |
When the first line of the manifest file is blank, currFuncs is null, but will be dereferenced to check if the current module will be empty. This CL fixes that and also cleans up the logic to clarify how the state machine works.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the first line of the manifest file is blank, currFuncs is null, but will be dereferenced to check if the current module will be empty.
This CL fixes that and also cleans up the logic to clarify how the state machine works.