Repository navigation
Add Ipsum, the new default theme for 7.2 - #14558
MaggieCabrera wants to merge 5 commits into
Conversation
Imports the theme files from https://github.com/WordPress/ipsum at b3a4bca4d69624fc2579b2cdd834ad4a30df9273. Repository tooling and development docs stay in the GitHub repository. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sets the version to 1.0 and "Tested up to" to 7.2, uses the `=== Name ===` readme title and the release changelog entry of the other bundled themes, and ends every file with a newline. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adds Ipsum to the default themes in `WP_Theme`, to the new bundled files installed on upgrade and to the tested themes, and sets `WP_DEFAULT_THEME` to `ipsum`. Ipsum moves away from year-based names, so the test for the default theme list no longer expects a `twenty` prefix. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The build, PHPCS, the PHP compatibility check and PHPStan only pick up bundled themes named `twenty*`, so Ipsum is added to each of them. Without this, Ipsum would be missing from builds and packages. Ipsum is also added to the empty file check and ZIP jobs of the default themes workflow. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
@desrosj pinging you here for your knowledge with default theme stuff |
|
Props list for the theme as of today:
|
Like the other block default themes since Twenty Twenty-Two, Ipsum requires the release it ships in. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
peterwilsoncc
left a comment
There was a problem hiding this comment.
I know this is a WIP but I've added a note inline.
For the @font-face and image files, is it possible to add a cache busting string to the rendered version, ie ?ver=20261021, either via a filter or in theme.json? It's helpful for cache busting on sites with long caches for static files.
Thirty days or longer is pretty typical these days as lighthouse calls out shorter caching headers.
As with the inline comment, this isn't a blocker. Not even close...
There was a problem hiding this comment.
A few naming things suggestions for this file. I don't think they block the initial commit but would be good to change prior to the production release.
The key word above is suggestions, feel free to push back:
ipsum_register_editor_stylesipsum_add_theme_supportipsum_enqueue_stylesipsum_register_block_styles
Nitty nit nit pick: as I say, feel free to push back :)
There was a problem hiding this comment.
Imports Ipsum from https://github.com/WordPress/ipsum and makes it the default theme for WordPress 7.2.
Trac ticket: https://core.trac.wordpress.org/ticket/66352
Ipsum drops the year-based naming, and a few places only look for
twenty*themes:wp-content/themes/twenty*, so Ipsum would be missing from builds and packages.test_default_theme_in_default_theme_list()expected atwentyprefix.The commits can land separately, like the Twenty Twenty-Five import and its follow-up:
Version: 1.0,Tested up to: 7.2, the readme title and changelog entry, and a final newline in every file. These need to go back to the Ipsum repository too, so the next sync doesn't undo them.WP_DEFAULT_THEME,WP_Theme::$default_themes,$_new_bundled_filesand the tested themes to change together.Testing Instructions
npm run test:php -- --group themes. All tests pass.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Comparing this with earlier default theme imports, preparing the commits, running the checks, and testing Ipsum on Playground with WordPress 7.1 and 7.2 without Gutenberg. I reviewed all the changes.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code