Skip to content

Add support for atom reachability integration - #2273

Open
ziadhany wants to merge 10 commits into
aboutcode-org:mainfrom
ziadhany:atom_symbols
Open

Add support for atom reachability integration#2273
ziadhany wants to merge 10 commits into
aboutcode-org:mainfrom
ziadhany:atom_symbols

Conversation

@ziadhany

@ziadhany ziadhany commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Issues

Checklist

  • I have read the contributing guidelines
  • I have linked an existing issue above
  • I have added unit tests covering the new code
  • I have reviewed and understood every line of this PR

@ziadhany
Add support for atom reachability integration
e9090fe 
Signed-off-by: ziadhany <ziadhany2016@gmail.com>
@ziadhany
Update atom pipeline and add docs
d79ebf2 
Signed-off-by: ziadhany <ziadhany2016@gmail.com>
@TG1999 TG1999 mentioned this pull request Oct 22, 2026
Closed
@ziadhany
Update atom pipeline and docs
f15e819 
Signed-off-by: ziadhany <ziadhany2016@gmail.com>
@ziadhany
ziadhany requested a review from keshav-space October 22, 2026 09:20
@ziadhany
Add missing license header for analyze_atom_reachability.py file
e49d167 
Signed-off-by: ziadhany <ziadhany2016@gmail.com>
ziadhany
ziadhany commented Oct 22, 2026
View reviewed changes
Comment thread docs/tutorial_atom_reachability_integration_tools.rst Outdated
@ziadhany
Update atom command to set cache to none
38f8522 
Fix docs bug

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
@ziadhany
Fix a bug on getting the main project primary_language
3dc07fd 
Signed-off-by: ziadhany <ziadhany2016@gmail.com>
@ziadhany
Add support for atom to work with docker
e51bcb1 
Signed-off-by: ziadhany <ziadhany2016@gmail.com>
keshav-space
keshav-space requested changes Oct 27, 2026
View reviewed changes

@keshav-space keshav-space left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ziadhany, see some questions and suggestions below.

Comment thread scanpipe/pipelines/analyze_atom_reachability.py Outdated
Comment thread scanpipe/pipelines/analyze_atom_reachability.py Outdated
Comment thread scanpipe/pipelines/analyze_atom_reachability.py Outdated
Comment thread scanpipe/pipelines/analyze_atom_reachability.py Outdated
Comment thread scanpipe/pipelines/analyze_atom_reachability.py Outdated
Comment thread scanpipe/pipes/atom.py Outdated
Comment thread scanpipe/pipes/atom.py Outdated
@ziadhany
Refactor and Improve the atom pipeline.
19dddb7 
 Move AtomTool to pipes

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
@ziadhany
Avoid using @classmethod or @staticmethod when they aren't necessary
f50639d 
Signed-off-by: ziadhany <ziadhany2016@gmail.com>
@ziadhany
ziadhany requested a review from keshav-space October 27, 2026 13:36
keshav-space
keshav-space requested changes Oct 27, 2026
View reviewed changes

@keshav-space keshav-space left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ziadhany LGTM, do we need to include atom slice in output?

Comment thread docker-compose.yml Outdated
cp -a /usr/local/lib/node_modules/. /atom-root/lib/node_modules/
ln -sfn /atom-root/opt/wrapper/nodejs/packages/atom /atom-root/opt/wrapper/nodejs/packages/atom-jar /atom-root/lib/node_modules/@appthreat/
printf '#!/bin/sh\nexport LD_LIBRARY_PATH=/atom-root/lib\nexport JAVA_HOME=/atom-root/opt/java/26.0.1-tem\nexport PATH=/atom-root/opt/java/26.0.1-tem/bin:/atom-root/opt/maven/3.9.16/bin:/atom-root/opt/sbt/1.12.12/bin:/atom-root/opt/scala/3.8.4/bin:/atom-root/opt/vendor/bin:$$PATH\nexec /atom-root/bin/node /atom-root/opt/wrapper/nodejs/packages/atom/index.js "$$@"\n' > /atom-root/bin/atom
chmod +x /atom-root/bin/atom

@keshav-space keshav-space Oct 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should move this to a atom Dockerfile.

@ziadhany

ziadhany commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@ziadhany LGTM, do we need to include atom slice in output?
We have four output files, according to my understanding of the atom tool.

  • atom_reachability-2026-10-27-13-20-03.python.reachables.slices.json JSON, easy to view, and can be used to determine the source-to-sink flows using CLI .
  • atom_reachability-2026-10-27-13-20-03.python.usages.slices.json JSON, easy to view, and can be used to determine where and how libraries are used
  • atom_reachability-2026-10-27-13-20-03.python.atom can be imported, queried, and viewed using other tools such as https://github.com/AppThreat/chen
  • reachability-2026-10-27-13-22-08.json our final report

I think it’s useful to keep them in the output, as they can help with manual debugging and review if further investigation is needed.

@ziadhany
Move entrypoint to atom.Dockerfile
069306f 
fix a typo in the docs

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
@ziadhany
ziadhany requested a review from keshav-space October 28, 2026 02:20
@ziadhany ziadhany mentioned this pull request Oct 28, 2026
Merged

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keshav-space keshav-space Awaiting requested review from keshav-space

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ziadhany @keshav-space