Repository navigation
fix(sender): settle sends when the loop terminates - #170
Open
Ehsan-hash wants to merge 2 commits into
Open
Ehsan-hash wants to merge 2 commits into
Ehsan-hash wants to merge 2 commits into
Conversation
Developed with AI assistance using Codex. Regression tests intentionally fail until the sender lifecycle fix follows.
Retain writer failures for active, queued and later sends. Preserve cancellation during shutdown and reject sends after closure, including cancellation before the sender loop starts. Developed and reviewed with AI assistance using Codex.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When the sender loop fails or is cancelled, concurrent requests can wait forever for a send that will never complete. Keep a terminal sender state so active, queued and later sends all finish.
What changed
Connection.Scope
Blast Radius
Changes how pending sends terminate after writer failure or shutdown. Existing peer cancellation, stdio and HTTP/WebSocket tests pass.
Verification
5 failed, 7 passed; fixed focused regressions:12 passed.75 passed.make checkpasses;make test:413 passed, 1 skippedon Python 3.12. The skipped Gemini integration was not enabled.Developed and reviewed with AI assistance using Codex. No live model/provider calls were used for validation.