[cexbrayat]

PR Checklist

Please check to confirm your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

The only auto formatting supported out if the box is prettier

What is the new behavior?

If the project has oxfmt installed, then oxfmt is preferred. Prettier is then used as a fallback to preserve the existing behavior.

Does this PR introduce a breaking change?

• Yes
• No

Other information

[gemini-code-assist]

Code Review

This pull request refactors the Angular CLI formatting utility to support both oxfmt and prettier as formatters, renaming the utility file and updating imports and tests accordingly. The review feedback suggests improving robustness and performance by caching the resolved formatter path at the module level to avoid redundant disk I/O. Additionally, it points out that the --no-error-on-unmatched-pattern flag should only be passed to prettier, as oxfmt uses strict argument parsing and will fail if an unknown option is provided.

[gemini-code-assist]

Improve robustness and implement caching when resolving the formatter:

1. Wrap the entire resolution, file reading, and JSON parsing inside the try-catch block to prevent any unexpected errors (e.g., missing/malformed package.json or missing bin field) from crashing the CLI.
2. Safely check if bin is a string or an object containing the formatter name before calling path.join to avoid a TypeError if bin or bin[name] is undefined.
3. Use the module-level formatterCache to cache the resolved formatter details.

  let cacheEntry = formatterCache.get(cwd);
  if (!cacheEntry) {
    const workspaceRequire = createRequire(cwd + '/');
    let formatterCliPath: string | null = null;
    let formatter: string | undefined;

    for (const name of ['oxfmt', 'prettier']) {
      try {
        const packageJsonPath = workspaceRequire.resolve(`${name}/package.json`);
        const { bin } = JSON.parse(await readFile(packageJsonPath, 'utf-8')) as {
          bin?: string | Record<string, string>;
        };
        const binPath = typeof bin === 'string' ? bin : bin?.[name];
        if (binPath) {
          formatterCliPath = join(dirname(packageJsonPath), binPath);
          formatter = name;
          break;
        }
      } catch {
        continue;
      }
    }

    cacheEntry = { cliPath: formatterCliPath, formatter };
    formatterCache.set(cwd, cacheEntry);
  }

  const { cliPath: formatterCliPath, formatter } = cacheEntry;

[cexbrayat]

Let me know if this should be done

[gemini-code-assist]

Only pass --no-error-on-unmatched-pattern when the formatter is prettier. oxfmt (and other oxc-based tools) use strict argument parsing (via Rust's clap library) and will fail with an error if an unknown option like --no-error-on-unmatched-pattern is passed, preventing any files from being formatted.

Suggested change

	const baseArgs = [formatterCliPath, '--write', '--no-error-on-unmatched-pattern'];
	if (formatter === 'prettier') {
	baseArgs.push('--ignore-unknown');
	}
	const baseArgs = [formatterCliPath, '--write'];
	if (formatter === 'prettier') {
	baseArgs.push('--no-error-on-unmatched-pattern', '--ignore-unknown');
	}

[cexbrayat]

Oxfmt 0.74.0 supports --no-error-on-unmatched-pattern https://oxc.rs/docs/guide/usage/formatter/cli.html#runtime-options

[gemini-code-assist]

To avoid redundant disk I/O and package resolution when formatFiles is called multiple times (e.g., during multiple migrations in a loop), we should cache the resolved formatter path and name. We can define a cache Map at the module level.

Suggested change

	const execFileAsync = promisify(execFile);
	let prettierCliPath: string | null | undefined;
	const execFileAsync = promisify(execFile);
	const formatterCache = new Map<string, { cliPath: string | null; formatter?: string }>();

[cexbrayat]

Let me know if that should be done