Repository navigation
refactor: simplify Set operations with ES2025 Set methods - #34505
Closed
alan-agius4 wants to merge 3 commits into
Closed
alan-agius4 wants to merge 3 commits into
alan-agius4 wants to merge 3 commits into
Conversation
alan-agius4
added
the
target: minor
alan-agius4
added
the
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors various Set operations across the codebase to utilize modern ECMAScript Set methods, such as union, intersection, difference, isSubsetOf, and isDisjointFrom. This replaces manual loops and filter operations, resulting in cleaner, more readable, and more idiomatic code. There are no review comments to address, and I have no additional feedback to provide as the changes are clean and correct.
clydin
approved these changes
Oct 23, 2026
alan-agius4
removed
the
action: review
…S2025 Set methods
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
angular-robot
pushed a commit
to angular-robot/angular-cli
that referenced
this pull request
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace manual
Setiteration, array spreading, and.filter()chains with native ES2025Setmethods (isDisjointFrom,isSubsetOf,union,intersection, anddifference) across@angular/buildand@angular-devkit/core.