Repository navigation
Revert "perf(@angular/build): avoid web worker channel overhead in library parallel compilation" - #34506
Merged
alan-agius4 merged 1 commit intoOct 23, 2026
Conversation
…brary parallel compilation" This reverts commit bcdcc09.
crisbeto
approved these changes
Oct 23, 2026
There was a problem hiding this comment.
Code Review
This pull request simplifies parallel compilation by making the web worker channel and signal mandatory rather than optional, removing conditional logic for library builds. It also changes stylesheet request IDs from incrementing numbers to UUIDs. The review feedback suggests replacing randomUUID with Math.random().toString(36) to avoid the performance overhead of cryptographically secure generation and to remove the unnecessary node:crypto import.
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
alan-agius4
deleted the
fix/22.2.x-revert-library-parallel-compilation
branch
October 23, 2026 08:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts
bcdcc09fb7on22.2.x, which was cherry-picked frommain(7f4de14688) and referencesbuildType(library), a22.3.x(target: minor) feature not present on22.2.x.