Skip to content

Revert "perf(@angular/build): avoid web worker channel overhead in library parallel compilation" - #34506

Merged
alan-agius4 merged 1 commit into
angular:22.2.xfrom
alan-agius4:fix/22.2.x-revert-library-parallel-compilation
Oct 23, 2026
Merged

alan-agius4 merged 1 commit into
angular:22.2.xfrom
alan-agius4:fix/22.2.x-revert-library-parallel-compilation

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

Reverts bcdcc09fb7 on 22.2.x, which was cherry-picked from main (7f4de14688) and references buildType (library), a 22.3.x (target: minor) feature not present on 22.2.x.

…brary parallel compilation"

This reverts commit bcdcc09.
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Oct 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies parallel compilation by making the web worker channel and signal mandatory rather than optional, removing conditional logic for library builds. It also changes stylesheet request IDs from incrementing numbers to UUIDs. The review feedback suggests replacing randomUUID with Math.random().toString(36) to avoid the performance overhead of cryptographically secure generation and to remove the unnecessary node:crypto import.

@alan-agius4
alan-agius4 merged commit ed30336 into angular:22.2.x Oct 23, 2026
36 checks passed
@alan-agius4

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4
alan-agius4 deleted the fix/22.2.x-revert-library-parallel-compilation branch October 23, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants