Skip to content

GH-1357: parse Flight SQL JDBC boolean properties case-insensitively - #1358

Open
Arawoof06 wants to merge 1 commit into
apache:mainfrom
Arawoof06:jdbc-boolean-property-case-insensitive
Open

Arawoof06 wants to merge 1 commit into
apache:mainfrom
Arawoof06:jdbc-boolean-property-case-insensitive

Conversation

@Arawoof06

Copy link
Copy Markdown
Contributor

What's Changed

ArrowFlightConnectionProperty.getBoolean only treated 1 and the exact lowercase true as true, and connection-string values are not normalized, so useEncryption=TRUE (or True) parsed as false. Since useEncryption defaults to true and drives withEncryption, that silently downgraded the connection to plaintext and sent the auth handshake and credentials in the clear. This compares true case-insensitively while still honoring 1, matching how JDBC drivers normally parse boolean options.

Closes #1357.

@jbonofre jbonofre added the bug-fix PRs that fix a big. label Oct 30, 2026
@apache apache deleted a comment from github-actions Bot Oct 30, 2026
@jbonofre jbonofre added this to the 20.0.0 milestone Oct 30, 2026

@jbonofre jbonofre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@jbonofre
jbonofre force-pushed the jdbc-boolean-property-case-insensitive branch from 0beffd7 to b19a189 Compare October 30, 2026 09:54
@jbonofre

Copy link
Copy Markdown
Member

I rebased to have the CI green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix PRs that fix a big.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flight SQL JDBC parses boolean properties case-sensitively, silently disabling TLS for useEncryption=TRUE

2 participants