Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused validation change follows definition-level semantics and includes regression coverage for both accepted and rejected cases.
No open issues 🎉
What changed in this PR
Fixes Parquet writing of required child fields whose null values are masked by null ancestors, addressing GH-55124 while preserving rejection of unmasked nulls.
Changes:
- Validate required leaf nulls against ancestor definition levels.
- Preserve definition levels for required leaves so invalid nulls remain detectable.
- Add regression coverage for masked nulls, null and empty lists, and invalid unmasked nulls.
| File | Description |
|---|---|
cpp/src/parquet/column_writer.cc |
Distinguishes masked from unmasked required-leaf nulls. |
cpp/src/parquet/arrow/path_internal.cc |
Prevents required-leaf nulls from lowering definition levels. |
cpp/src/parquet/arrow/arrow_reader_writer_test.cc |
Tests valid masked nulls and rejection of unmasked nulls. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The Parquet writer checks the leaf array's physical null count without accounting for the parent struct's validity bitmap. As a result, it rejects nulls in required child fields even when they are masked by null parent rows.
What changes are included in this PR?
Corrected the logic used by the column writer to validate the null values for required leaf fields.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: