Repository navigation
Conversation
|
What happened was.. I recently added decorations on upstream/main. Domenico pointed me that the HD_ROUTE_TO should not be decorated as these queueIDs belong to another broker (another journal). So I removed the decoration, but had forgotten to remove / adapt the tests (which were actually generated by AI). I am fixing the tests / removing them. As of proper decoaring the HDR_ROUTE_TO, we would need to load the bindings of the target node... we could do that with an optional feature (like provide the bindings of a remote node), but I think that's an overkill for a feature I would personally like to have replaced by federation / amqp federation. Thanks for the PR though. |
|
I sent this PR to address this: #6843 |
|
Thanks for explaining. I hadn't noticed the route-to IDs come from the other broker's journal ( |
DescribeJournal.decorateRouteToPropertiesprinted each queue ID in a message's_AMQ_ROUTE_TOproperties without its queue name, though the queue names were inBrokerInfo. References and acks are decorated throughdecorateQueueName; the route-to IDs were not, soDescribeJournalTest.testDecorateRouteToSingleQueue,testDecorateRouteToMultipleQueuesandtestDecorateRouteToClusterPropertyfail on main, and every build since 4d82196 stops atartemis-server.Each route-to ID is now followed by
decorateQueueName(id, brokerInfo), which adds(queueName), or nothing for an ID that is not a known queue.DescribeJournalTestpasses, 6 of 6. It fails without the fix.https://issues.apache.org/jira/browse/ARTEMIS-6242