Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Problem Summary:
IOBufCuttercan peek at only one byte withfetch1(). Parsers that need to inspect multiple bytes before consuming them lack an API that respects the cutter’s current position. Reading directly from the underlyingIOBufmay include bytes already consumed by the cutter.What is changed and the side effects?
Changed:
IOBufCutter::fetch(void*, size_t) constto peek at multiple bytes without advancing the cursor.nullptron insufficient data without modifying the auxiliary buffer.buf()to expose a const reference to the underlyingIOBufwithout synchronizing the cursor.Side effects:
Check List:
git diff --cached --check.