Skip to content

config cleanup - #13884

Draft
DaanHoogland wants to merge 51 commits into
mainfrom
ghi10752-configCleanup
Draft

config cleanup#13884
DaanHoogland wants to merge 51 commits into
mainfrom
ghi10752-configCleanup

register missing ConfigKeys and fix tests still stubbing Configuratio…

f7a0c3e
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Oct 22, 2026 in 8m 59s

Quality Gate failed

Failed conditions
23.9% Coverage on New Code (required ≥ 40%)
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 116 in server/src/main/java/com/cloud/configuration/Config.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Hidden" 5 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit8tyQ7ncxF0NCQ_w&open=AaFit8tyQ7ncxF0NCQ_w&pullRequest=13884

Check warning on line 5648 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit8gjQ7ncxF0NCQ_t&open=AaFit8gjQ7ncxF0NCQ_t&pullRequest=13884

Check failure on line 52 in api/src/main/java/com/cloud/deploy/DeploymentClusterPlanner.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Advanced" 6 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit4UPQ7ncxF0NCQ-m&open=AaFit4UPQ7ncxF0NCQ-m&pullRequest=13884

Check failure on line 25 in engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/StorageCacheManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Storage" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit38xQ7ncxF0NCQ-f&open=AaFit38xQ7ncxF0NCQ-f&pullRequest=13884

Check failure on line 192 in server/src/main/java/com/cloud/user/AccountManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Advanced" 4 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit8LnQ7ncxF0NCQ_q&open=AaFit8LnQ7ncxF0NCQ_q&pullRequest=13884

Check failure on line 63 in server/src/main/java/com/cloud/server/ManagementServer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Specify the private bridge on host for private network" 5 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit7z5Q7ncxF0NCQ_R&open=AaFit7z5Q7ncxF0NCQ_R&pullRequest=13884

Check failure on line 45 in server/src/main/java/com/cloud/server/ManagementServer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "false" 7 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit7z5Q7ncxF0NCQ_T&open=AaFit7z5Q7ncxF0NCQ_T&pullRequest=13884

Check warning on line 880 in server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit87PQ7ncxF0NCQ_0&open=AaFit87PQ7ncxF0NCQ_0&pullRequest=13884

Check warning on line 410 in plugins/network-elements/internal-loadbalancer/src/main/java/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit5IcQ7ncxF0NCQ-w&open=AaFit5IcQ7ncxF0NCQ-w&pullRequest=13884

Check failure on line 389 in server/src/main/java/com/cloud/server/StatsCollector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename field "storageStatsInterval" to prevent any misunderstanding/clash with field "StorageStatsInterval". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit75mQ7ncxF0NCQ_Y&open=AaFit75mQ7ncxF0NCQ_Y&pullRequest=13884

Check warning on line 304 in server/src/main/java/com/cloud/api/query/dao/DomainRouterJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit6N9Q7ncxF0NCQ-9&open=AaFit6N9Q7ncxF0NCQ-9&pullRequest=13884

Check warning on line 581 in server/src/main/java/com/cloud/server/ConfigurationServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit7z0Q7ncxF0NCQ_O&open=AaFit7z0Q7ncxF0NCQ_O&pullRequest=13884

Check failure on line 30 in api/src/main/java/org/apache/cloudstack/usage/UsageService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Usage" 7 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit4QIQ7ncxF0NCQ-k&open=AaFit4QIQ7ncxF0NCQ-k&pullRequest=13884

Check failure on line 90 in server/src/main/java/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Advanced" 7 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit6gmQ7ncxF0NCQ_F&open=AaFit6gmQ7ncxF0NCQ_F&pullRequest=13884

Check warning on line 397 in server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit6J_Q7ncxF0NCQ-7&open=AaFit6J_Q7ncxF0NCQ-7&pullRequest=13884

Check warning on line 152 in server/src/main/java/com/cloud/alert/AlertManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "_vlanCapacityThreshold" field and declare it as a local variable in the relevant methods. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit8GSQ7ncxF0NCQ_l&open=AaFit8GSQ7ncxF0NCQ_l&pullRequest=13884

Check failure on line 82 in server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "false" 4 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit7BnQ7ncxF0NCQ_K&open=AaFit7BnQ7ncxF0NCQ_K&pullRequest=13884

Check warning on line 171 in server/src/main/java/com/cloud/api/query/dao/DiskOfferingJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit5_kQ7ncxF0NCQ-2&open=AaFit5_kQ7ncxF0NCQ-2&pullRequest=13884

Check failure on line 284 in server/src/main/java/com/cloud/server/StatsCollector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "60000" 5 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit75mQ7ncxF0NCQ_V&open=AaFit75mQ7ncxF0NCQ_V&pullRequest=13884

Check warning on line 365 in server/src/main/java/com/cloud/api/query/dao/VolumeJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit6R0Q7ncxF0NCQ-_&open=AaFit6R0Q7ncxF0NCQ-_&pullRequest=13884

Check warning on line 887 in server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit87PQ7ncxF0NCQ_2&open=AaFit87PQ7ncxF0NCQ_2&pullRequest=13884

Check warning on line 58 in engine/schema/src/main/java/com/cloud/user/AccountDetailsDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit3MiQ7ncxF0NCQ-a&open=AaFit3MiQ7ncxF0NCQ-a&pullRequest=13884

Check warning on line 120 in server/src/main/java/com/cloud/api/query/dao/ImageStoreJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit572Q7ncxF0NCQ-0&open=AaFit572Q7ncxF0NCQ-0&pullRequest=13884

Check warning on line 882 in server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit87PQ7ncxF0NCQ_1&open=AaFit87PQ7ncxF0NCQ_1&pullRequest=13884

Check warning on line 230 in server/src/main/java/com/cloud/api/query/dao/SnapshotJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFit6BfQ7ncxF0NCQ-3&open=AaFit6BfQ7ncxF0NCQ-3&pullRequest=13884
View more details on SonarQubeCloud