Repository navigation
Conversation
|
@blueorangutan package |
|
@Damans227 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14392 +/- ##
============================================
- Coverage 20.21% 20.21% -0.01%
+ Complexity 20750 20747 -3
============================================
Files 6426 6426
Lines 580181 580183 +2
Branches 71033 71033
============================================
- Hits 117287 117283 -4
- Misses 450180 450185 +5
- Partials 12714 12715 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19531 |
2e2b897 to
c8b5f51
Compare
winterhazel
left a comment
There was a problem hiding this comment.
@Damans227 let's also add a || sourceToken.isCancel(error) to the if condition of line 1303 of AutogenView.vue (the one with console.log("API request likely got cancelled due to route change" insde it), so that canceled promises do not throw an error in the console.
Fixes #14381
When you switch projects while a list page is still loading, the UI cancels the old request on purpose. The shared error handler saw a failed request with no reply and showed "canceled - Unable to reach the management server or a browser extension may be blocking the Network request." This makes the handler skip requests the UI cancelled itself, so nothing is shown. Real network errors still show the warning..
Test:
Create a project with an instance. Select the project, open Compute > Instances, then switch to Default view while the list is still loading. The lab is fast, so the instance list reply was held back 3 seconds in the browser to switch while it was still loading. The browser console shows the same cancel as the issue:
Before: from #14381:
After: no warning, only the switch message: