[weizhouapache]

Description

This reverts commit bb5da0e.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[weizhouapache]

This reverts #10594 which caused #14099 #14432 in ACS 4.23.0 and current upstream.

The script file is critical for public cloud providers, the script before #10594 has been proved to be working for several years. To reduce the impact, it would be better to revert the changes.

cc @wido

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.45%. Comparing base (af9764b) to head (fe1520f).

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #14443   +/-   ##
=========================================
  Coverage     20.45%   20.45%           
- Complexity    21415    21416    +1     
=========================================
  Files          6487     6487           
  Lines        589303   589303           
  Branches      72245    72245           
=========================================
+ Hits         120525   120536   +11     
+ Misses       455643   455632   -11     
  Partials      13135    13135           

Flag	Coverage Δ
uitests	3.70% <ø> (ø)
unittests	21.75% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19672

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-17204)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 68598 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr14443-t17204-kvm-ol8.zip
Smoke tests completed. 155 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_primary_storage_nfs	Error	0.23	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	Error	0.42	test_primary_storage.py
test_01_primary_storage_scope_change	Error	0.17	test_primary_storage_scope.py