Skip to content

use ConfigKeys for UCS settings and remaining getValue() literals - #14472

Open
DaanHoogland wants to merge 1 commit into
ghi10752-config-foundationfrom
ghi10752-config-literals
Open

DaanHoogland wants to merge 1 commit into
ghi10752-config-foundationfrom
ghi10752-config-literals

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

Switches the UCS settings and the remaining string-literal ConfigurationDao.getValue("...") lookups to ConfigKeys.

Part 6 of 12 of the split of #13884 (phase out the deprecated Config enum, #10752). Base: ghi10752-config-foundation. Independent of the other PRs based on the foundation, so it can be reviewed and merged in any order relative to them; GitHub retargets it to main once the foundation is merged.

Size: 17 files, +195/-60.

Split overview: foundation → parallel PRs (account, vpn-vpc, snapshot-usage, event-bus, literals) + stacked core-1 … core-5 → enum-removal (last).

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Local verification: full reactor build (checkstyle included) and the unit tests of every touched module pass on this branch; merging all PRs of the split in any order gives no conflicts and reproduces #13884 plus its fixes.

🤖 Generated with Claude Code

Part of the split of #13884 (phase out the Config enum, #10752).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.70%. Comparing base (d58e94b) to head (60908ad).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           ghi10752-config-foundation   #14472   +/-   ##
===========================================================
  Coverage                        3.70%    3.70%           
===========================================================
  Files                             493      493           
  Lines                           42558    42558           
  Branches                         8063     8063           
===========================================================
  Hits                             1578     1578           
  Misses                          40751    40751           
  Partials                          229      229           
Flag Coverage Δ
uitests 3.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant