Skip to content

use ConfigKeys for assorted management server, VMware, XenServer and baremetal settings - #14477

Open
DaanHoogland wants to merge 2 commits into
ghi10752-config-core-4from
ghi10752-config-core-5
Open

use ConfigKeys for assorted management server, VMware, XenServer and baremetal settings#14477
DaanHoogland wants to merge 2 commits into
ghi10752-config-core-4from
ghi10752-config-core-5

update ResourceManagerImplTest and ManagementServerImplTest for Confi…

4e4d120
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Oct 23, 2026 in 7m 29s

Quality Gate failed

Failed conditions
11.5% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 260 in server/src/main/java/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJM3QDzH0MnfOd3lk&open=AaFpJM3QDzH0MnfOd3lk&pullRequest=14477

Check warning on line 1243 in server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJNPrDzH0MnfOd3lo&open=AaFpJNPrDzH0MnfOd3lo&pullRequest=14477

Check warning on line 410 in plugins/network-elements/internal-loadbalancer/src/main/java/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJMP3DzH0MnfOd3lW&open=AaFpJMP3DzH0MnfOd3lW&pullRequest=14477

Check warning on line 1202 in services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJNtbDzH0MnfOd3lt&open=AaFpJNtbDzH0MnfOd3lt&pullRequest=14477

Check warning on line 410 in plugins/network-elements/internal-loadbalancer/src/main/java/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJMP3DzH0MnfOd3lV&open=AaFpJMP3DzH0MnfOd3lV&pullRequest=14477

Check warning on line 304 in server/src/main/java/com/cloud/api/query/dao/DomainRouterJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJMvGDzH0MnfOd3lh&open=AaFpJMvGDzH0MnfOd3lh&pullRequest=14477

Check warning on line 1429 in server/src/test/java/com/cloud/configuration/ConfigurationManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJNlMDzH0MnfOd3lr&open=AaFpJNlMDzH0MnfOd3lr&pullRequest=14477

Check warning on line 3502 in server/src/main/java/com/cloud/user/AccountManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJNTjDzH0MnfOd3lp&open=AaFpJNTjDzH0MnfOd3lp&pullRequest=14477

Check warning on line 82 in engine/schema/src/test/java/com/cloud/storage/dao/StoragePoolTagsDaoImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the "@Override" annotation above this method signature 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJL4ADzH0MnfOd3lU&open=AaFpJL4ADzH0MnfOd3lU&pullRequest=14477

Check warning on line 783 in server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJMoYDzH0MnfOd3le&open=AaFpJMoYDzH0MnfOd3le&pullRequest=14477

Check warning on line 171 in server/src/main/java/com/cloud/api/query/dao/DiskOfferingJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJMfLDzH0MnfOd3la&open=AaFpJMfLDzH0MnfOd3la&pullRequest=14477

Check warning on line 1235 in server/src/main/java/com/cloud/resource/ResourceManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJM-2DzH0MnfOd3lm&open=AaFpJM-2DzH0MnfOd3lm&pullRequest=14477

Check warning on line 2510 in server/src/test/java/com/cloud/server/ManagementServerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJNoHDzH0MnfOd3ls&open=AaFpJNoHDzH0MnfOd3ls&pullRequest=14477

Check warning on line 230 in server/src/main/java/com/cloud/api/query/dao/SnapshotJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJMhWDzH0MnfOd3lb&open=AaFpJMhWDzH0MnfOd3lb&pullRequest=14477

Check warning on line 365 in server/src/main/java/com/cloud/api/query/dao/VolumeJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJMzIDzH0MnfOd3li&open=AaFpJMzIDzH0MnfOd3li&pullRequest=14477

Check warning on line 397 in server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJMqvDzH0MnfOd3lf&open=AaFpJMqvDzH0MnfOd3lf&pullRequest=14477

Check warning on line 230 in server/src/main/java/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJMY6DzH0MnfOd3lX&open=AaFpJMY6DzH0MnfOd3lX&pullRequest=14477

Check warning on line 343 in server/src/main/java/com/cloud/api/query/dao/StoragePoolJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJMtCDzH0MnfOd3lg&open=AaFpJMtCDzH0MnfOd3lg&pullRequest=14477

Check warning on line 2301 in server/src/main/java/com/cloud/api/ApiDBUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Immediately return this expression instead of assigning it to the temporary variable "providerDnsName". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJM6iDzH0MnfOd3ll&open=AaFpJM6iDzH0MnfOd3ll&pullRequest=14477

Check warning on line 101 in server/src/main/java/com/cloud/api/query/dao/ResourceTagJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJM1KDzH0MnfOd3lj&open=AaFpJM1KDzH0MnfOd3lj&pullRequest=14477

Check warning on line 297 in server/src/main/java/com/cloud/api/query/dao/AccountJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJMjcDzH0MnfOd3lc&open=AaFpJMjcDzH0MnfOd3lc&pullRequest=14477

Check warning on line 160 in server/src/main/java/com/cloud/api/query/dao/AffinityGroupJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJMdDDzH0MnfOd3lZ&open=AaFpJMdDDzH0MnfOd3lZ&pullRequest=14477

Check warning on line 2088 in server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJNB_DzH0MnfOd3ln&open=AaFpJNB_DzH0MnfOd3ln&pullRequest=14477

Check warning on line 120 in server/src/main/java/com/cloud/api/query/dao/ImageStoreJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJMa_DzH0MnfOd3lY&open=AaFpJMa_DzH0MnfOd3lY&pullRequest=14477

Check warning on line 269 in server/src/main/java/com/cloud/api/query/dao/DomainJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFpJMlkDzH0MnfOd3ld&open=AaFpJMlkDzH0MnfOd3ld&pullRequest=14477
View more details on SonarQubeCloud