You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Restrict type hints from Any for many functions #1507
The following comment on PR #1484. See the issue for further context.
One small nit. It probably makes sense to just land this then resolve the nit (if desired).
Follow on opportunities mostly reviewing functions (just grepped for lit), raw Any isn't great so we could potentially find a slightly narrower type:
in_list values: list[Expr | Any?]
Remove the lit in the count_star example (unrelated to changes here but in the spirit of showing we don't need lit nearly anywhere there are actually a bunch of filters that use lit that I don't think they need
Probably can use this approach to build out further lit coverage (CaseBuilder example as a part of functions)
round doc string has a for example that can probably just be pruned for the doc string example
make_array *args: Expr | Any
range Expr | float?
named_struct list[tuple[str, Expr | Any]]
array_append
array_has
array_position, index covered but element could be extended
Activity