Skip to content

Parse the DEFERRABLE transaction mode - #2505

Open
LucaCappelletti94 wants to merge 3 commits into
apache:mainfrom
LucaCappelletti94:deferrable-transaction-mode
Open

LucaCappelletti94 wants to merge 3 commits into
apache:mainfrom
LucaCappelletti94:deferrable-transaction-mode

Conversation

@LucaCappelletti94

@LucaCappelletti94 LucaCappelletti94 commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Parses DEFERRABLE and NOT DEFERRABLE, PostgreSQL extensions documented in SET TRANSACTION.

@LucaCappelletti94
LucaCappelletti94 marked this pull request as ready for review September 13, 2026 20:48
@LucaCappelletti94
LucaCappelletti94 force-pushed the deferrable-transaction-mode branch 4 times, most recently from b2dfc75 to 26202df Compare September 22, 2026 21:03
LucaCappelletti94 added a commit to LucaCappelletti94/sqlparser-rs that referenced this pull request Oct 1, 2026
@LucaCappelletti94
LucaCappelletti94 force-pushed the deferrable-transaction-mode branch from e2d4527 to 5361adf Compare October 2, 2026 16:14
@codecov-commenter

codecov-commenter commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.31%. Comparing base (bfc7d38) to head (4a499ca).
⚠️ Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
src/ast/mod.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2505      +/-   ##
==========================================
+ Coverage   81.09%   81.31%   +0.21%     
==========================================
  Files          42       42              
  Lines       33682    33985     +303     
  Branches    33682    33985     +303     
==========================================
+ Hits        27316    27636     +320     
+ Misses       2796     2785      -11     
+ Partials     3570     3564       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94 LucaCappelletti94 added enhancement New feature or request waiting on reviewer PR needs to be reviewed labels Oct 16, 2026

@sabir-akhadov-localstack sabir-akhadov-localstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking comment inline.

Comment thread tests/sqlparser_common.rs Outdated

#[test]
fn parse_transaction_deferrable_mode() {
// The third transaction mode of the SQL standard, spelled the same in

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEFERRABLE is a PostgreSQL extension, not a SQL-standard mode (the Compatibility section of the linked page says so); same for the PR description.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right I was being dyslexic there. I am unsure why I was so convinced of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request PostgreSQL waiting on reviewer PR needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants