Repository navigation
SQLite: Tokenize parameters the way SQLite does - #2559
Open
LucaCappelletti94 wants to merge 4 commits into
Open
LucaCappelletti94 wants to merge 4 commits into
LucaCappelletti94 wants to merge 4 commits into
Conversation
LucaCappelletti94
marked this pull request as ready for review
September 23, 2026 13:46
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2559 +/- ##
==========================================
+ Coverage 81.52% 81.53% +0.01%
==========================================
Files 42 42
Lines 34205 34253 +48
Branches 34205 34253 +48
==========================================
+ Hits 27885 27929 +44
- Misses 2770 2773 +3
- Partials 3550 3551 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
added a commit
to LucaCappelletti94/sqlparser-rs
that referenced
this pull request
Oct 1, 2026
LucaCappelletti94
added a commit
to LucaCappelletti94/sqlparser-rs
that referenced
this pull request
Oct 2, 2026
LucaCappelletti94
added a commit
to LucaCappelletti94/sqlparser-rs
that referenced
this pull request
Oct 2, 2026
LucaCappelletti94
force-pushed
the
sqlite-variable-tokens
branch
from
October 2, 2026 16:14
ccdf0fe to
f6dda60
Compare
LucaCappelletti94
force-pushed
the
sqlite-variable-tokens
branch
2 times, most recently
from
October 17, 2026 08:16
44ced5f to
c329836
Compare
sabir-akhadov-localstack
left a comment
Contributor
There was a problem hiding this comment.
Needs a rebase: tests/sqlparser_sqlite.rs conflicts with main, and see inline for a silent one.
| ch == '`' || ch == '"' || ch == '[' | ||
| } | ||
|
|
||
| fn get_next_precedence(&self, parser: &Parser) -> Option<Result<u8, ParserError>> { |
Contributor
There was a problem hiding this comment.
#2683 already added get_next_precedence to this impl (&/| at Precedence::Ampersand); git auto-merges both without a marker and the result has two definitions, so fold the Token::Colon arm into that match.
LucaCappelletti94
force-pushed
the
sqlite-variable-tokens
branch
from
October 21, 2026 07:52
86c0227 to
f33b435
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
SQLiteDialecttokenize$,@,:and#parameters with SQLite's rules. Names may start with a digit (except after#), contain$and any non-ASCII character, and carry the TCL style::namespace and(...)suffix.The parameter forms are documented under parameters.