Repository navigation
MySQL: Keep literal prefixes as identifiers after a period - #2688
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2688 +/- ##
=======================================
Coverage 81.52% 81.53%
=======================================
Files 42 42
Lines 34205 34218 +13
Branches 34205 34218 +13
=======================================
+ Hits 27885 27898 +13
Misses 2770 2770
Partials 3550 3550 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
tokenizer-prefix-after-period
branch
from
October 20, 2026 10:49
bb91320 to
4879487
Compare
alamb
approved these changes
Oct 20, 2026
LucaCappelletti94
force-pushed
the
tokenizer-prefix-after-period
branch
from
October 21, 2026 07:47
4879487 to
ccfdce0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL accepts
SELECT t.x'ff' FROM tas columnxwith aliasff, and similarly accepts qualified columns namedbandn. The tokenizer recognizes a prefixed literal after the period, so these queries fail to parse. Qualified-name rules are documented by MySQL and MariaDB.Dialect::supports_literal_prefix_in_qualified_name()enables identifier tokenization immediately after a period for MySQL and the generic dialect. Whitespace or comments after the period retain literal tokenization, as do unqualified prefixes. Other dialects retain their literal handling.