Repository navigation
chore: renormalize mvnw.cmd line endings - #1265
Open
yebuguntang wants to merge 2 commits into
Open
yebuguntang wants to merge 2 commits into
yebuguntang wants to merge 2 commits into
Conversation
Author
|
Hi @GOODBOY008 , could you review this small fix? It resolves #1264 — mvnw.cmd always shows as modified after cloning on Windows. Verified the stored blob becomes LF while the checked-out file is unchanged. Thanks! |
Mikkey-f
reviewed
Nov 2, 2026
Mikkey-f
left a comment
Contributor
There was a problem hiding this comment.
Verified on Windows 11:
- On current
main:git ls-files --eol mvnw.cmd→i/crlf w/crlf attr/text eol=crlf, and a fresh worktree reportsM mvnw.cmd— reproduces #1264. - On this PR:
i/lf w/crlf attr/text eol=crlf, andgit status --porcelainis clean. git diff --ignore-cr-at-eol origin/main...HEADis empty, so only the stored line endings change; the checked-out script stays CRLF for cmd.exe.
LGTM — this fixes the fresh-clone symptom, and existing clones pick it up on pull.
GOODBOY008
self-requested a review
November 2, 2026 09:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Closes #1264
mvnw.cmdalways shows as modified ingit statusafter cloning, even though nobody changed the file..gitattributessays*.cmdblobs are stored as LF, but this one was committed with CRLF before the rule existed (#1049).What's changed?
git add --renormalize mvnw.cmdThe stored blob becomes LF. The file Windows users check out is unchanged, same hash before and after. Verified:
git ls-files --eolnow reportsi/lf w/crlf--ignore-cr-at-eolcomes back emptygit statusis clean after the commitmvnw.cmd -DskipTests packagestill buildsNo docs or test changes needed — this only touches how the file is stored in git, not its content.
Checklist