Repository navigation
HBASE-30495 Incorrect remote RPC retry count when reopening a scanner - #8816
Open
liuxiaocs7 wants to merge 1 commit into
Open
liuxiaocs7 wants to merge 1 commit into
liuxiaocs7 wants to merge 1 commit into
Conversation
liuxiaocs7
commented
Oct 26, 2026
liuxiaocs7
commented
Member
- see: HBASE-30495
There was a problem hiding this comment.
🟢 Approval recommended
The narrow fix matches the metrics contract, and the regression tests cover both affected error paths for local and remote servers.
No open issues 🎉
What changed in this PR
Fixes HBASE-30495 in the asynchronous scan client so remote RPC retries during scanner reopening are counted based on server locality, rather than whether the scanner is closed.
Changes:
- Passes
regionServerRemoteto the retry-metrics helper. - Adds regression tests for scanner-reset and out-of-order errors, covering both local and remote servers.
| File | Description |
|---|---|
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncScanSingleRegionRpcRetryingCaller.java |
Tests retry counts and scanner-close behavior across error and locality combinations. |
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncScanSingleRegionRpcRetryingCaller.java |
Corrects the locality flag used to count remote retries. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.