Repository navigation
fix(vermeer): align release version - #370
Merged
Merged
Conversation
- Synchronize Vermeer with Computer 1.8.0 - Check both release versions in Vermeer CI - Run the check when the Computer POM changes
- Use a GitHub Actions glob for release branches - Run version checks on release branch pushes - Preserve existing workflow path filters
- report the master version under the correct label - report the worker version under the correct label - cover registration failures for mismatched versions
bitflicker64
reviewed
Nov 3, 2026
bitflicker64
left a comment
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The version bump, the swapped mismatch message, the release-* glob and the POM-to-version.go CI check are correct, but the new registration test never runs in vermeer-ci.yml. A pre-existing build.sh version parse also mangles the release tarball name.
- select the registration version test in CI - extract the version constant without license text - keep archive and Docker version values consistent
bitflicker64
approved these changes
Nov 3, 2026
bitflicker64
left a comment
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: version.go matches the Computer revision 1.8.0, the mismatch message reports master and worker versions under the right labels, and CI checks both versions and runs the new registration test. build.sh and build_docker.sh read only the const Version line, which resolves the earlier tarball-name comment.
MrJs133
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Vermeer reports 1.7.0 even though Computer is at 1.8.0. Align its version with the release and check the two declarations in CI.
Master rejects Workers reporting a different version, so deploy matching Master and Worker images together and account for an unavailable interval during the transition.
Validation