Repository navigation
fix(vermeer): reject incomplete Louvain output - #371
Merged
imbajin merged 2 commits intoNov 3, 2026
Merged
Conversation
- reject output before the first pass completes - preserve cancellation and report actionable errors - cover output validation and task control
bitflicker64
reviewed
Nov 3, 2026
bitflicker64
left a comment
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: ValidateOutput correctly rejects output while firstStep is true, and the RunOutput reorder keeps cancel and pause handling ahead of validation. vermeer-ci.yml never runs ./algorithms, so the new Louvain test does not run in CI.
- run algorithm tests with the race detector - include Louvain output regression coverage - retain existing worker test checks
bitflicker64
approved these changes
Nov 3, 2026
bitflicker64
left a comment
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: ValidateOutput rejects Louvain output while firstStep is true, which only compute.max_step can reach, and RunOutput keeps cancel and pause handling ahead of it; CI now runs ./algorithms and the tests pass at this head.
MrJs133
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Louvain and weighted Louvain can be stopped before the first iteration completes. Reading output in that state could panic or return intermediate state. Reject output until the first iteration finishes, while preserving cancellation and pause handling.
Validation