Repository navigation
Fix local IndexQuery result deserialization - #13743
Open
timoninmaxim wants to merge 1 commit into
Open
timoninmaxim wants to merge 1 commit into
timoninmaxim wants to merge 1 commit into
Conversation
timoninmaxim
force-pushed
the
fix/local-index-query-binary
branch
from
October 23, 2026 21:49
f98246e to
302700b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Local
IndexQueryreturned binary keys and values even when the cache was queried withoutwithKeepBinary(). Both local and distributed queries obtain binary entries fromIndexQueryProcessor, but only the distributed path converts them after merging sorted pages.Convert entries when the local query iterator builds its result, after the shared index processor. This preserves binary entries for distributed merge sorting. Add a regression test with POJO keys and values that checks local regular and keep-binary queries and a sorted distributed query.
Testing
mvn -pl modules/indexing -am -Dtest=IndexQueryLocalTest -Dsurefire.failIfNoSpecifiedTests=false -DFORK_COUNT_SET_TO_1 test(Java 17): 5 tests passed.BinaryObjectImplfor localIndexQueryon Ignite 2.17.0 and 2.18.0 before the fix.