Repository navigation
Conversation
matthiasblaesing
left a comment
There was a problem hiding this comment.
Makes sense to me, but I think only java/java.mx.project/build.xml was intended for this commit. The rest of the changes seem to be picked up from a4be9f9.
|
oh thanks for noticing. not sure how this happened. |
build clones an EOL version of graalvm and mx and builds it.
65e104b to
5f23efe
Compare
jtulach
left a comment
There was a problem hiding this comment.
Thanks for the fix. If it makes the CI green, then it is a good fix.
|
btw this is the highest version i could update it to before graalvm switched to the modular version and each lang became a module. So the next time it fails we are stuck. |
|
basically still #6925 (comment) i would guess since the version numbers line up - but I didn't investigate further. Most of the NB's GraalVM specific tests were written expecting certain languages being supported by the grallvm dist out of the box and never got updated due to lack of interest. We keep hotfixing them when something fails.
yes please do and update test dependencies to more recent versions so that we get ahead of the test-failure curve and have some buffer again. From the test data perspective it probably also makes sense to test against something which is still supported by someone. If possible: we should try to find a way how to not clone other repos during tests, e.g can this be tested differently? |
it clones an EOL version of graalvm and mx and builds it, the recent Upuntu update broke it, again.
failures were on build-tools job and build system (build all tests). We removed the GraalVM job back in april (#9319).
targets delivery right now but I am not sure if there will be another RC.