Repository navigation
audioutils: Add CMake build support for morsey and rtttl-c - #3920
Open
Swatantra-66 wants to merge 1 commit into
Open
Swatantra-66 wants to merge 1 commit into
Swatantra-66 wants to merge 1 commit into
Conversation
Closes the CMake build-system parity gap in apps/audioutils: - audioutils/morsey: Adds CMakeLists.txt with FetchContent tarball download, public header symlinking, and library integration into apps. - audioutils/rtttl-c: Adds CMakeLists.txt with FetchContent shallow clone, public header symlinking, and library integration into apps. - Follows standard NuttX FetchContent conventions matching other submodules, with preapps configuration safety and public header symlink generation under include/audioutils. Signed-off-by: Swatantra Yadav <maverickswatantra@gmail.com>
Swatantra-66
force-pushed
the
cmake/audioutils
branch
from
October 26, 2026 05:01
2fc6f77 to
b171095
Compare
Contributor
Author
|
Removed the SHA checks and streamlined both CMakeLists.txt to follow the standard NuttX FetchContent pattern matching other submodules |
xiaoxiang781216
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses apache/nuttx#19549 by closing the CMake build-system parity gap in
apps/audioutilsaudioutils/morsey:Adds
CMakeLists.txtusing CMakeFetchContentto download the upstreamv1.0.1release tarball.Implements automated SHA-256 integrity verification for
morsey.candmorsey.hmatchingMakefile.Exports the public header via symlink to
${NUTTX_APPS_BINDIR}/include/audioutils/morsey.h.Compiles
morsey.cand registers private include paths with theappslibrary target.audioutils/rtttl-c:Adds
CMakeLists.txtusing CMakeFetchContentto shallow clone tagv0.1.0.Implements automated SHA-256 integrity verification for
rtttl.candrtttl.hmatchingMakefile.Exports the public header via symlink to
${NUTTX_APPS_BINDIR}/include/audioutils/rtttl.h.Compiles
rtttl.cand registers private include paths with theappslibrary target.Robustness & Edge-Case Safety (both modules):
Preapps Safety: Conditioned on
if(CONFIG_* AND TARGET apps)to prevent premature evaluation during early Kconfig generation.Offline Build Overrides: Honors
FETCHCONTENT_SOURCE_DIR_MORSEY_FETCHandFETCHCONTENT_SOURCE_DIR_RTTTL_C_FETCHwithout attempting network access.Local Edit Preservation: Rejects missing/incomplete checkouts with a fatal error if local files exist, refusing to delete developer modifications or Make checkouts.
Subbuild Reset: Wipes sub-build state under
${FETCHCONTENT_BASE_DIR}to ensure recovery when a fresh download is needed.Symlink Refresh: Unconditionally invokes
nuttx_create_symlinkto refresh exported header links whenever the active source directory changes.Impact
New feature added: Yes, CMake build support for
audioutils/morseyandaudioutils/rtttl-c.Existing behavior changed: No, existing Make builds remain 100% untouched.
Build process: Enables building both modules when configuring with CMake (
-DCONFIG_AUDIOUTILS_MORSEY=yand-DCONFIG_AUDIOUTILS_RTTTL_C=y).Compatibility: Fully compliant with
cmake-format(0 warnings/errors).Testing
Host: Ubuntu 24.04 (WSL2 / Windows 11 x86_64), GCC 15.2.0, CMake 4.2.3, Ninja 1.13.2
Target:
sim:nsh(-DCONFIG_AUDIOUTILS_MORSEY=y -DCONFIG_AUDIOUTILS_RTTTL_C=y)Build Logs:
Style & Format Verification: