Repository navigation
Conversation
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #621
Motivation
With GCC 15.3.0 and 16.2.1 at
-O2,testAllocatedContentsintests/MessageTest.ccfails to compile under the project's-Werrorsetting. It usesstrncpyto copystr.length()bytes, omitting the terminating NUL. The test passes the buffer with an explicit byte count, so a NUL terminator is not required:memcpyexpresses the intended byte copy without triggering-Wstringop-truncation.Modifications
Replace
strncpywithmemcpyfor the samestr.length()bytes. The content and length passed to the message are unchanged.Verifying this change
This change is already covered by existing tests, such as
MessageTest.testAllocatedContents, which builds and passes with the change.Documentation
doc-not-needed(Only the setup of an existing test changes; no public API or user-facing behavior changes.)