[snoopdave]

Blogroll links are kept to web and relative URLs:

• OPML import keeps a bookmark's link and feed URL only when they are absolute http or https URLs.
• Templates get bookmark URLs through WeblogBookmarkWrapper only when they are relative or use http, https, ftp or mailto, so links stored by earlier imports are covered too.
• The blogroll macro in weblog.vm escapes the URLs it prints in attributes.

Tests: BookmarkImportParsingTest (import keeps only web links) and WeblogBookmarkWrapperTest. Full build and tests pass on JDK 11.

[snoopdave]

🤖 GLM: PR-Review — 1 inline comment posted.

[snoopdave]

Important: webLinkOrNull silently drops any outline whose URL fails URI parsing — including ordinary human URLs with unencoded spaces (http://example.com/a b, covered by the new test). Whole bookmarks vanish from the import with no feedback to the user beyond a debug-level log. Consider at least logging the drop at WARN with the outline name, and a CHANGES.md note that OPML entries are now kept only when their htmlUrl/xmlUrl are absolute http(s) URLs, so users understand why previously-importable entries disappear.

[snoopdave]

🤖Claude: fixed by logging each skipped outline at WARN with its name and URL (and a WARN when only the feed URL is dropped), plus a CHANGES.md entry (cb1ec31).

[snoopdave]

🤖 GLM: PR-Review — General Issues

The following issues were found but cannot be attached to a specific line in the diff:

• Important: CHANGES.md has no entry for this change. Other PRs in the 6.1.7 batch (e.g. ROL-2184: Preserve pasted entry images when publishing #205, Filter HTML-significant characters out of tag names #208, Serve media found by a custom theme under the media rules #217) each carry one. The user-facing parts worth a note: OPML import now keeps only absolute http(s) links (entries with other URLs are dropped, including ones with unencoded spaces), and blogroll URLs reach templates only when relative or http/https/ftp/mailto — links stored by earlier versions that use other schemes now render as empty.

Strengths worth noting (not action items): the two-layer approach (import-time validation plus the wrapper's scheme allow-list for stored values) covers data written before this change, and webLinkOrNull requiring a host is a nice strictness touch; the new tests cover both layers.

[snoopdave]

🤖Claude: fixed by adding a CHANGES.md entry under 6.1.7 behaviour changes (cb1ec31).