Skip to content

Bump dependencies to fix security alerts - #240

Merged
wu-sheng merged 1 commit into
masterfrom
bump/security-deps-2026-11-02
Nov 3, 2026
Merged

wu-sheng merged 1 commit into
masterfrom
bump/security-deps-2026-11-02

Conversation

@wu-sheng

@wu-sheng wu-sheng commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Bump golang.org/x/net in swctl past the versions OSV flags, regenerate dist/LICENSE, and move CI to current GitHub Actions majors and skywalking-infra-e2e.

Dependencies

Module Old New Manifest Advisories
golang.org/x/net (indirect) v0.60.0 v0.62.0 go.mod GO-2026-6860, GO-2026-6866
golang.org/x/crypto (indirect) v0.57.0 v0.58.0 go.mod required by x/net v0.62.0
golang.org/x/text v0.42.0 v0.43.0 go.mod required by x/net v0.62.0
golang.org/x/sys, x/sync, x/term (indirect) v0.48.0, v0.23.0, v0.46.0 v0.49.0, v0.24.0, v0.47.0 go.mod required by x/net v0.62.0

govulncheck on master lists both x/net advisories in a required module but not reachable from swctl code. CHANGES.md: one line under a new 0.16.0 Bug Fixes section (0.15.0 is released).

GitHub Actions

  • actions/checkout v3/v4 -> v7
  • actions/setup-go v4/v5 -> v7
  • actions/upload-artifact v4 -> v7
  • The same checkout/setup-go bump in the actions/setup composite action this repository publishes

infra-e2e

apache/skywalking-infra-e2e cf589b4 -> 56ac8be (current main, CI green) in the three e2e jobs. The action sets up Go 1.26 itself to build e2e.

The newer verifier requires every entry of a contains block to match a distinct actual item (apache/skywalking-infra-e2e#137, #143); the old one accepted a partial match. test/cases/basic/expected/dependency-instance.yml expected the consumer -> provider instance call to carry both SERVER and CLIENT detect points, but the OAP reports only SERVER for it, so the case failed on 56ac8be. The expectation now lists SERVER only. Checked locally with e2e verify built at 56ac8be against the actual output from the failed run: the new file passes and the old one fails the same way CI did.

License

dist/LICENSE regenerated with license-eye dependency resolve at the Makefile's pin (d38fe05); only the x/* version lines change. The same run on master produced no diff, so there was no earlier drift. dist/licenses is unchanged.

Verified locally (Go 1.27.1)

  • go build ./...: pass
  • go test ./...: pass (11 packages)
  • make license-header: pass
  • Not run: make lint (golangci-lint is not installed here), the e2e jobs

Left out on purpose

  • golang.org/x/crypto GO-2026-5932 (openpgp is unmaintained) has no fixed version; govulncheck finds it unreachable.

@wu-sheng
wu-sheng force-pushed the bump/security-deps-2026-11-02 branch from 1f4fbfa to ac9f310 Compare November 2, 2026 17:06
@wu-sheng wu-sheng added this to the 0.16.0 milestone Nov 2, 2026
- golang.org/x/net v0.60.0 -> v0.62.0 (GO-2026-6860, GO-2026-6866),
  with golang.org/x/crypto v0.58.0, x/sync v0.24.0, x/sys v0.49.0,
  x/term v0.47.0 and x/text v0.43.0 by minimum version selection.
- dist/LICENSE regenerated with license-eye (d38fe05); only the version
  lines change. CHANGES.md updated.

GitHub Actions: actions/checkout v3/v4 -> v7, actions/setup-go v4/v5
-> v7, actions/upload-artifact v4 -> v7, in the workflows and in the
actions/setup composite action.

infra-e2e: apache/skywalking-infra-e2e cf589b4 -> 56ac8be in the three
e2e jobs. Its verifier now requires every entry of a `contains` block
to match a distinct actual item (infra-e2e #137, #143). The basic
case's dependency-instance expectation listed a CLIENT detect point
the instance relation never reports (the OAP returns only SERVER); the
old verifier accepted the partial match. The expected file now lists
SERVER only.
@wu-sheng
wu-sheng force-pushed the bump/security-deps-2026-11-02 branch from ac9f310 to b2324ce Compare November 3, 2026 00:36
@wu-sheng
wu-sheng merged commit 5cf816d into master Nov 3, 2026
7 checks passed
@mrproliu
mrproliu deleted the bump/security-deps-2026-11-02 branch November 3, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants