Skip to content

Bump dependencies to fix security alerts - #150

Merged
wu-sheng merged 2 commits into
masterfrom
bump/security-deps-2026-11
Nov 2, 2026
Merged

wu-sheng merged 2 commits into
masterfrom
bump/security-deps-2026-11

Conversation

@wu-sheng

@wu-sheng wu-sheng commented Nov 2, 2026

Copy link
Copy Markdown
Member

Bumps dependencies flagged by open Dependabot alerts, plus the GitHub Actions used by CI.

Rust extension (Cargo.lock)

  • rustls 0.23.43 -> 0.23.46 (GHSA-2mjx-qc3c-rqvc). Done with cargo update -p rustls, which kept the Rust 1.85 MSRV (rust-version = "1.85"). Cargo also re-pointed a few Windows-only dependency edges from windows-sys 0.52.0 to 0.60.2. Both versions were already in the lockfile.
  • dist-material/LICENSE updated to match. license-eye dependency resolve --summary (the License workflow's check) regenerates it with no diff.

PHP test project (tests/php/composer.lock, test-only)

Produced with composer update guzzlehttp/guzzle guzzlehttp/psr7 phpseclib/phpseclib --with-all-dependencies. The resolution used a temporary platform.php = 7.2.5 so the lock stays installable on the lowest PHP in the CI matrix (7.2). That override is not committed: composer.json is unchanged and the content-hash matches it. composer why-not --locked php 7.2.5 reports no blockers.

GitHub Actions

  • actions/checkout v2 -> v7 (all workflows). The workflows only use push, pull_request and release triggers, so the v7 fork-checkout block for pull_request_target/workflow_run does not apply.
  • Swatinem/rust-cache 9d47c6ad4b02e050fd481d890b2ea34778fd09d6 (v2.7.8) -> d1527c8f67ef9af357290475d4af4b0fab8f12e0 (v2.9.3)
  • shivammathur/setup-php stays on @v2, which is already its latest major.
  • apache/skywalking-eyes stays on d299844e. With v0.9.0, license-eye dependency check fails locally on this repo's config ("Apache-2.0 unknown or incompatible"). Moving to it needs a separate config change.

This repo has no skywalking-infra-e2e usage. The Linux jobs already call docker compose (v2), and the runners are pinned to ubuntu-24.04 / macos-14, so no Docker 29 changes were needed.

Left as is

  • time 0.3.45 (GHSA-r6v5-fh4h-64xc, CVE-2026-25727): every patched release (>= 0.3.47) requires Rust 1.88. This repo's documented MSRV and CI toolchain are 1.85, so the fix needs an MSRV bump, which is out of scope for this PR.

Verified locally

  • cargo check --locked -p skywalking-php-worker: passes. This builds the skywalking/tonic/tokio-rustls/rustls path.
  • cargo check --workspace: blocked locally because bindgen 0.71.1 (from phper-sys) panics on the macOS PHP 8.5.4 headers ("unknown calling convention"). This also happens without these changes. CI covers the full build.
  • license-eye header check, dependency check and dependency resolve --summary: all pass, and dist-material/LICENSE has no diff.
  • composer validate --no-check-publish: valid. composer audit --locked: no advisories. composer install --dry-run --ignore-platform-req=ext-swoole: resolves.
  • Not run locally: clippy on the 1.85 toolchain, cargo test (needs docker compose services), and the PECL build. CI on this PR covers them.

- Cargo.lock: rustls 0.23.43 -> 0.23.46 (GHSA-2mjx-qc3c-rqvc).
  dist-material/LICENSE updated to match.
- tests/php/composer.lock: guzzlehttp/guzzle 7.4.5 -> 7.16.1,
  guzzlehttp/psr7 2.5.0 -> 2.13.2, phpseclib/phpseclib 3.0.35 -> 3.0.57,
  with their dependencies, resolved against PHP 7.2.5 so the CI matrix
  (PHP 7.2 - 8.5) can still install the lock.
- actions/checkout v2 -> v7
- Swatinem/rust-cache v2.7.8 -> v2.9.3 (SHA pinned)
@wu-sheng wu-sheng added this to the 1.2.0 milestone Nov 2, 2026
@wu-sheng
wu-sheng merged commit 2dcbf5a into master Nov 2, 2026
18 checks passed
@wu-sheng
wu-sheng deleted the bump/security-deps-2026-11 branch November 2, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants