Repository navigation
fix(release-finalize): guard the tag target on a release-PR merge - #24
Merged
Merged
Conversation
On a release-PR merge the tag goes on the PR head (the commit the checks ran on, for a base branch that keeps moving while the PR is open) or on the merge commit (for a base branch that is a release line, as the backend's main). Three aragon/app flows tagged the merge commit of a moving main: the assistant 0.3.1 finalize failed its changesets guard on two changesets merged after the branch was cut. A guard now fails the run when 'sha' is neither, or when it is not reachable from the base branch (a squashed release PR). Docs and examples say which target fits which base branch.
tyhonchik
force-pushed
the
fix/finalize-tag-tested-head
branch
from
October 28, 2026 11:32
2f00a0e to
a04d987
Compare
tyhonchik
changed the title
jjavieralv
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a release-PR merge the tag goes on the PR head or on the merge commit, and which one follows what the base branch is. A base branch that keeps moving while the release PR is open (aragon/app: feature merges into
main) gets the PR head, the commit the checks ran on; the merge commit would also carry what landed in the meantime, built and tested by nobody under that version. A base branch that is a release line and receives nothing but release and hotfix merges (aragon/app-backend:main, back-merged intodevelopment, hotfixes ported into open releases) gets the merge commit, which is the base branch itself.Three aragon/app flows tagged the merge commit of a moving
main: the assistant 0.3.1 finalize failed its changesets guard on two changesets merged after the branch was cut (run).Changes
release-finalize.yml: on apull_requestevent the run fails before tagging whenshais neither the PR head nor the merge commit, or when it is not reachable from the base branch (a squashed release PR). Non-PR callers (hotfix flows) are untouched.No interface change (
shastays required). The app flows switch to the head in aragon/app#1533; the backend keeps the merge commit; aragon-indexer already passes the head.🤖 Generated with Claude Code