Repository navigation
Conversation
In ProfileHandler._import_profile_from_url(), after processing the downloaded profile file and calling self.remove_custom_profiles(profiles) to replace any existing definition, self.add_custom_profiles(profiles) was never called (unlike the local file path in parse_profile_config()). As a result, profiles imported via a URL in profile_config['path'] were never added to self._profiles and get_profile_by_name() returned None. Call self.add_custom_profiles(profiles) after remove_custom_profiles().
Kolgrim33
force-pushed
the
fix/import-profile-from-url
branch
from
October 25, 2026 17:15
e2da1cd to
fc826af
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
In
ProfileHandler._import_profile_from_url(), after downloading and parsing the profile file viaself._process_profile_file(filepath),self.remove_custom_profiles(profiles)was called to clear any existing profile with the same name, butself.add_custom_profiles(profiles)was missing (unlike the local file branch inparse_profile_config()).Consequently, custom profiles imported from a URL in
profile_config['path']were never registered inself._profiles, causingself.get_profile_by_name(main)to returnNone.This PR adds the missing
self.add_custom_profiles(profiles)call and a unit test intests/test_profile_url_import.py.Tests and Checks