Repository navigation
Conversation
runWithInvokeContext only stored REQUEST_ID and X_RAY_TRACE_ID in the InvokeStore, never TENANT_ID. The JSON loggers read tenantId via invokeStore.getTenantId() (PROTECTED_KEYS.TENANT_ID), so it was always undefined, fell back to "", and formatJsonMessage's `if (tenantId)` guard dropped the field. The header was parsed correctly onto context.tenantId (hence available in code and platform events), but that value never reached the store the loggers consult. Thread context.tenantId through runWithInvokeContext and set PROTECTED_KEYS.TENANT_ID for both the single- and multi-concurrent call sites so tenantId appears in custom JSON log entries, matching the documented behavior and the Python runtime. Add regression tests covering both call sites. tenantId is pinned to the sandbox, so it stays constant across every invocation in the execution environment's lifecycle (unlike requestId/traceId). Ref: V2290595765 cr: https://code.amazon.com/reviews/CR-290016955
Reuse the existing JSON-log test to verify tenantId is emitted as a top-level field in JSON-formatted logs, per review feedback on CR-290016955. cr: https://code.amazon.com/reviews/CR-290016955
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runWithInvokeContextstored only the request ID and X-Ray trace ID in the InvokeStore, never the tenant ID. The JSON loggers readtenantIdfrom the store, so it was alwaysundefined, fell back to"", and theif (tenantId)guard dropped the field, even though it was correctly parsed ontocontext.tenantId.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.