Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wasabi returns
TemporarilyUnavailablefor transient storage failures. The XML marshaller treats this unknown name as non-retryable, even on HTTP 503, aborting multipart uploads instead of retrying the affected part.Map it to retryable
SERVICE_UNAVAILABLE, with regression tests for XML classification and unchanged unknown/NoSuchKey behavior.Reproduced using ClickHouse 26.9.4.3 and loopback mock S3: identical 503 responses fail after one part attempt with
TemporarilyUnavailable, but retry successfully withServiceUnavailable.Draft: SDK unit tests/build verification pending. Also proposed in ClickHouse#41. This changes generated code; guidance on the preferred non-generated compatibility hook is welcome.