Skip to content

feat(skills): add plan-based ADR writer - #252

Closed
rayyan224 wants to merge 1 commit into
rayyanalam/skills-07-validate-end-to-end-design-councilfrom
rayyanalam/skills-08-add-plan-based-adr-writer
Closed

rayyan224 wants to merge 1 commit into
rayyanalam/skills-07-validate-end-to-end-design-councilfrom
rayyanalam/skills-08-add-plan-based-adr-writer

Conversation

@rayyan224

Copy link
Copy Markdown
Collaborator

Summary

Render the chosen design plan and its alternatives as an ADR, keeping the input Motivation and the plan's change tables intact. Bundle the format and writing references with the new skill.

Part 8 of a stack that adds design skills under .claude/skills/. Stacked on rayyanalam/skills-07-validate-end-to-end-design-council; review and merge bottom-up.

Changes

 .claude/skills/adr-writer/SKILL.md                 | 172 +++++++++++++++++++++
 .../references/google-technical-writing.md         |  49 ++++++
 .../references/simplified-technical-english.md     |  29 ++++
 .../adr-writer/references/template-point-form.md   |  66 ++++++++
 4 files changed, 316 insertions(+)

Render the chosen design plan and its alternatives as an ADR, keeping the input Motivation and the plan's change tables intact. Bundle the format and writing references with the new skill.
@github-actions

Copy link
Copy Markdown

Interface Coverage

✅ All interface functions have test coverage.

@github-actions

Copy link
Copy Markdown

📊 Forge Coverage (src/lib/)

🟡 ≥95% across all metrics — some metrics below 99%.

File Lines Stmts Branches Funcs
🟡 B20FactoryLib.sol 97.70% 98.00% 100.00% 95.00%
🔴 test/lib/ForceFeeder.sol 0.00% 0.00% 100.00% 0.00%
🔴 test/lib/PrecompileProbe.sol 0.00% 0.00% 0.00% 0.00%
🟢 MockActivationRegistry.sol 100.00% 100.00% 100.00% 100.00%
🟢 MockActivationRegistryStorage.sol 100.00% 100.00% 100.00% 100.00%
🟢 MockB20.sol 100.00% 99.68% 100.00% 100.00%
🟢 MockB20Asset.sol 100.00% 100.00% 100.00% 100.00%
🟡 MockB20Factory.sol 98.96% 99.10% 100.00% 100.00%
🟢 MockB20Stablecoin.sol 100.00% 100.00% 100.00% 100.00%
🟢 MockB20Storage.sol 100.00% 100.00% 100.00% 100.00%
🟢 MockBaseTime.sol 100.00% 100.00% 100.00% 100.00%
🟡 MockPolicyRegistry.sol 100.00% 99.58% 97.78% 100.00%
🟢 MockPolicyRegistryStorage.sol 100.00% 100.00% 100.00% 100.00%
Total 97.14% 97.51% 98.21% 97.07%

Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).

@github-actions

Copy link
Copy Markdown

❌ Fork tests did not complete

No completed, non-empty suite was recorded. Check the workflow logs for build, setup, or execution errors.

@rayyan224

Copy link
Copy Markdown
Collaborator Author

Superseded by #256, which adds the finished skills in one PR.

@rayyan224
rayyan224 deleted the branch rayyanalam/skills-07-validate-end-to-end-design-council October 23, 2026 20:01
@rayyan224 rayyan224 closed this Oct 23, 2026
@rayyan224
rayyan224 deleted the rayyanalam/skills-08-add-plan-based-adr-writer branch October 23, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant