Skip to content

feat(skills): validate end-to-end ADR generation - #254

Closed
rayyan224 wants to merge 1 commit into
rayyanalam/skills-09-document-live-main-plan-selectionfrom
rayyanalam/skills-10-validate-end-to-end-adr-generation
Closed

rayyan224 wants to merge 1 commit into
rayyanalam/skills-09-document-live-main-plan-selectionfrom
rayyanalam/skills-10-validate-end-to-end-adr-generation

Conversation

@rayyan224

Copy link
Copy Markdown
Collaborator

Summary

The ADR end-to-end run passes on the practice case with a lint-clean main plan and valid ADR checks. No skill changes were needed.

Part 10 of a stack that adds design skills under .claude/skills/. Stacked on rayyanalam/skills-09-document-live-main-plan-selection; review and merge bottom-up.

Changes

The ADR end-to-end run passes on the practice case with a lint-clean main plan and valid ADR checks. No skill changes were needed.
@github-actions

Copy link
Copy Markdown

Interface Coverage

✅ All interface functions have test coverage.

@github-actions

Copy link
Copy Markdown

📊 Forge Coverage (src/lib/)

🟡 ≥95% across all metrics — some metrics below 99%.

File Lines Stmts Branches Funcs
🟡 B20FactoryLib.sol 97.70% 98.00% 100.00% 95.00%
🔴 test/lib/ForceFeeder.sol 0.00% 0.00% 100.00% 0.00%
🔴 test/lib/PrecompileProbe.sol 0.00% 0.00% 0.00% 0.00%
🟢 MockActivationRegistry.sol 100.00% 100.00% 100.00% 100.00%
🟢 MockActivationRegistryStorage.sol 100.00% 100.00% 100.00% 100.00%
🟢 MockB20.sol 100.00% 99.68% 100.00% 100.00%
🟢 MockB20Asset.sol 100.00% 100.00% 100.00% 100.00%
🟡 MockB20Factory.sol 98.96% 99.10% 100.00% 100.00%
🟢 MockB20Stablecoin.sol 100.00% 100.00% 100.00% 100.00%
🟢 MockB20Storage.sol 100.00% 100.00% 100.00% 100.00%
🟢 MockBaseTime.sol 100.00% 100.00% 100.00% 100.00%
🟡 MockPolicyRegistry.sol 100.00% 99.58% 97.78% 100.00%
🟢 MockPolicyRegistryStorage.sol 100.00% 100.00% 100.00% 100.00%
Total 97.14% 97.51% 98.21% 97.07%

Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).

@github-actions

Copy link
Copy Markdown

❌ Fork tests did not complete

No completed, non-empty suite was recorded. Check the workflow logs for build, setup, or execution errors.

@rayyan224

Copy link
Copy Markdown
Collaborator Author

Superseded by #256, which adds the finished skills in one PR.

@rayyan224 rayyan224 closed this Oct 23, 2026
@rayyan224
rayyan224 deleted the rayyanalam/skills-10-validate-end-to-end-adr-generation branch October 23, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant