Repository navigation
Conversation
Owner
Author
|
Migrated to pingcap#1388: pingcap#1388 This source PR is closed as part of the upstream migration; its historical timeline and checks remain here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed
This draft advances the standalone Rust owner for CP-REPLAYER (#152) without changing the SQL-serving binary or claiming production cutover.
tiproxy-replayercomposition root which currently accepts dry-run onlyfs,s3,gcs,azblob,oss, andcosKindBytesReview hardening
The second exact head addresses the independent semantic review:
command_ordinalto ordering, resume frontiers, checkpoint schema, and input identity2026-12-01Honest scope boundary
This is a foundation-only draft and does not close #152. The following remain intentionally fail-closed or deferred:
tiproxy-replayerrejects service mode, backend execution, dynamic input, wait-on-EOF, and SQL output in this slice.Supply-chain exception disclosure
The workspace is pinned to Rust 1.89 and Tokio 1.47.1. OpenDAL 0.53.3 is therefore used for the required provider set; its signer graph currently carries
RUSTSEC-2023-0071,RUSTSEC-2026-0194, andRUSTSEC-2026-0195. OpenDAL 0.58 resolves the quick-xml advisories but requires Rust 1.91.The exceptions are explicitly synchronized across cargo-audit, cargo-deny, and the repository-owned exception ledger with owner
@bb7133, rationale, and expiry2026-12-01. Exposure in this draft is bounded to an operator-run dry-run binary with trusted storage endpoints; backend and service modes fail closed. The OpenDAL/toolchain upgrade is required before enabling either deferred mode.Verification
make rust-testmake rust-lintcargo test -p replayer-core --lockedtests/replayer/differential/run.sh(Go/Rust equality + mutation detected)python3 rust/ci/check_vulnerability_exceptions.pyAudit dependencies and policy(cargo-audit + cargo-deny + exception ledger)git diff --checkIssue: #152