Repository navigation
Conversation
…es of the ct [u8]
…eing held in a Polynomial [i32; 256], it's now bit-packed into a [u8; 32].
…LVM lays out stack frames and give slightly better numbers
…nd sig on the heap, thus under-reporting
…pansion so that it doesn't get sucked into the caller's stack frame.
…ill memory-hygiene-in-rust.
…skill The Architecture paragraph introducing memory hygiene already names the skill; the stand-alone sentence under Stack Usage Benchmarks repeated it. Also "cast" -> "cost" in that paragraph. Assisted-by: Claude:claude-fable-5-1 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…reflect what it does
ounsworth
commented
Oct 25, 2026
|
|
||
| fn A_hat(&self) -> P::MatrixA { | ||
| self.sk.A_hat() | ||
| self.A_hat.clone() |
Contributor
Author
There was a problem hiding this comment.
Merge this PR after #179, and see if we can turn this into a lifetime'd borrow instead of a clone.
ounsworth
marked this pull request as ready for review
October 25, 2026 16:20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebasing replacement of #136
In short, I had Claude do a review for silent copies in the mlkem and mldsa lowmemory crates and it found a couple of instance of:
And similar patterns.
The net result is about a 2 - 4 kb reduction across the whole lowmemory suite, and also some tightening up in the non-optimized implementation.
Also, importantly, this PR preserves the lessons-learned in a new Claude skill `memory-hygiene-in-rust so that it's easier to audit future code for the same hidden memcpy's.