Repository navigation
#191 add zizmor pre commit configuration - #196
Merged
kattni merged 2 commits intoOct 22, 2026
Merged
Conversation
added 2 commits
October 19, 2026 23:04
…, disable credential persistence
kattni
approved these changes
Oct 22, 2026
kattni
left a comment
Contributor
There was a problem hiding this comment.
Thanks for getting this set up! Looks great.
We don't use pedantic mode on any other repo; the real concern is injection of environment variables, rather than the ${{}} syntax itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a zizmor pre-commit check, and fixes the issues it reports in the existing workflows.
Fixes #191
The Zizmor rules being corrected are:
persist-credentials: falsehas no side effects.${{ }}references, since zizmor only flags them in pedantic mode. The values are hard-coded in the workflow itself, so they can't be influenced by a PR. Let me know if you'd like me to change them too and I'll work on it.PR Checklist:
Assisted-by: Claude Code (Claude Opus 5.5)