Repository navigation
fix(descriptor): clarify descriptor key expression errors - #351
Closed
Chibey-max wants to merge 2 commits into
Closed
Chibey-max wants to merge 2 commits into
Chibey-max wants to merge 2 commits into
Conversation
Collaborator
|
Same comment here applies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
descriptorcommand treated descriptor key expressions returned bykey deriveas raw extended keys. As a result, users received a confusingBase58 parsing error when passing the output from
key derivetodescriptor.This change detects descriptor key expressions before raw key parsing and
returns a clear error explaining the accepted input format and where full
descriptors can be used.
Fixes #303