Repository navigation
Change unused address output to list - #355
emma31-dev wants to merge 3 commits into
Conversation
|
i tested this using the cargo test --test cli --features rpc test_new_and_unused_address and test passes |
|
@Ishaan-0706 I totally missed that thanks for the feedback I was thinking of just making it into a separate command so it has a separate test. I'll make the change now |
|
can i work on that part? |
|
@Ishaan-0706 sure thing. Thanks for the helping hand. |
0bc8b86 to
5e3b8aa
Compare
|
@emma31-dev is the work done? |
|
yes i've updated the test. it was a few lines fix i was wondering why u took so long. pull it and test wether its fixed on your end |
|
If you still want to help out work on some of the issues opened by me in the issues tab |
91d6085 to
15ca1cc
Compare
|
saw your pr on the issue #358 can i work on the test part ? |
15ca1cc to
404d8dc
Compare
|
@Ishaan-0706 sure. |
Return all unused external addresses instead of only the next one, wrapping results in ListResult.
404d8dc to
d1779e5
Compare
|
Comment applies. |
Description
This change updates the
UnusedAddressCommandto return all unused external addresses rather than only the next one. Previously, the command calledWallet::next_unused_addressand returned a single AddressResult, which could be misleading if multiple addresses had already been revealed but not yet used. The output type is nowListResult<AddressResult>, populated by iterating overWallet::list_unused_addresseson the external keychain. This gives users a complete picture of all addresses awaiting use, making the command more useful for wallet inspection and reducing the risk of address reuse caused by incomplete visibility. This pr solves issue #349 opened by me.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing