Repository navigation
Add backend-independent BLE CRTP framing - #613
Draft
rafael2reis wants to merge 1 commit into
Draft
rafael2reis wants to merge 1 commit into
rafael2reis wants to merge 1 commit into
Conversation
Encode UP fragments and decode DOWN notifications with bounded length/PID validation. Add standalone round-trip, malformed-input and recovery tests before introducing a BLE backend or bench policy. Assisted-by: OpenAI Codex
This was referenced Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add backend-independent BLE CRTP framing as a small prerequisite for the experimental driver in #611.
The module encodes UP fragments and reassembles DOWN notifications using the documented length-minus-one/PID format. Invalid sizes, orphaned/mismatched continuations, overflow and a new start during an incomplete packet raise FrameError and discard partial state. It does not register a transport, import Bleak, configure logging or add flight/bench policy.
Validation:
This splits the wire-format component out for review first. The dependent driver PR carries identical codec files until this prerequisite can be incorporated upstream. The remaining driver changes can be inspected with a direct tree comparison between the fork branches feat/ble-crtp-codec and feat/ble-bench-driver.
Developed with OpenAI Codex assistance. Draft pending contributor and maintainer review.