Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 8055841 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
limitOptionsaccepts primitive options, but its truthiness check skips thestylecallback for0,false, and''. Those options become blank rows, including when the cursor is on them.Check for
undefinedinstead so these values reach the existing formatter. The regression covers the rendered labels and the active option. This is a narrow fix to the exported helper, so I haven't opened a separate issue.For
[0, false, '', 1], with a formatter that adds brackets and marks the active row, the output changes from['', '', '', '[1]']to['[0]', '> [false]', '[]', '[1]'].Type of change
Validation
1835f415) and passes with the fix. The built package reproduces the same before/after result.TERM=xterm-256color:pnpm testpasses all 798 tests, including the package build.pnpm types,pnpm format,pnpm lint, andpnpm depspass.limitOptionstests pass. Four existingnotecolor snapshots fail identically on unchanged main; no snapshots or assertions were changed.GitHub CI and the preview are awaiting first-contributor workflow approval. The separate Detect Agent run failed while installing the shared automation repository (
npm install --prefix automation:Cannot read properties of null (reading 'edgesOut')), before detection ran.Checklist
pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure