Skip to content

Retry failed refs by the definition delta, not every changed name #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bompus merged 1 commit into from
Oct 27, 2026
Merged

Retry failed refs by the definition delta, not every changed name #559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/codegraph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,13 +1134,25 @@ export class CodeGraph {
// member reference through any binding (`LIST.includes(x)` after
// `import { LIST } from './constants'`), then re-resolve that set.
// On a sync where no failed ref matches, this is a few indexed
// lookups.
// lookups. The keys are the names whose bindings actually changed
// (the definition delta) plus the changed files' module keys: a
// failed ref keyed by a name whose repo-wide node set is untouched
// resolves exactly as before, so retrying it can only redo the
// miss. On a settings-style file with hundreds of untouched names,
// keying by every name the file carries made this hundreds of
// pointless re-resolutions per sync.
const tRetry = Date.now();
edgesBeforeRetry = this.queries.getMaxEdgeId();
const retryable = this.queries.getRetryableFailedReferences([...new Set([
...this.queries.getNodeNamesByFiles(result.changedFilePaths),
...result.changedFilePaths.flatMap(moduleReferenceKeys),
])]);
const retryNames = result.definitionDelta ?? [];
const retryKeys = retryNames.length > 0 || (result.addedFilePaths?.length ?? 0) > 0
? [...new Set([
...retryNames,
...result.changedFilePaths.flatMap(moduleReferenceKeys),
])]
: [];
const retryable = retryKeys.length > 0
? this.queries.getRetryableFailedReferences(retryKeys)
: [];
// A scoped package that a `tsconfig` path or a workspace package maps
// to an added file (`@excalidraw/common` to `packages/common/src/
// index.ts`) waits under its last segment, which that file's keys
Expand Down
Loading