Repository navigation
perf: halve resolver-worker page cache + reuse near-dup shingle sets - #561
Merged
Merged
Conversation
Each of the up-to-12 pool workers held a 32 MiB SQLite page cache — ~384 MiB summed inside the main process before any real working set. The workers do scattered point reads during resolution; -16384 (16 MiB) measured peak-RSS neutral-to-better on pretix (4.34 vs 4.24 GiB main) with identical-or-better wall time.
Every body in a candidate pair was tokenized and shingled twice: once to write its MinHash signature, again to score the pair's exact Jaccard. Keep the Set computed at sign time and hand it to the pair pass — on pretix the phase drops ~38% (458 -> 284 ms); identical pairs, identical scores.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
@coderabbitai review |
|
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two measured follow-ups to the resolver-pool work, stacked on the merged #558/#559/#560 tower:
cache_size32 → 16 MiB): reclaims ~200 MB of index-time RSS across the 12-worker pool. Benchmarked time-neutral (pretix-Bun 7.72 s vs 8.67 s baseline run, same-order variance).refreshNearDuplicatestokenized + shingled every changed body to MinHash-sign it, thenpairNearDuplicatesre-tokenized the same bodies to score pairs — ~9,200 duplicate tokenizations on pretix. AfreshSetsmap now hands the sign-timeSetto scoring. Near-duplicate phase on pretix: 458 → 284 ms (−38%), identical pairs and scores.Test plan
__tests__/near-duplicates.test.ts: 9/9 pass__tests__/resolver-pool-sizing.test.ts+__tests__/resolver-pool-engage.test.ts: green